Skip to content

Conversation

@brandonskiser
Copy link
Contributor

@brandonskiser brandonskiser commented May 8, 2025

Description of changes:

  • Trying to fix more broken tests in CI related to telemetry.
  • Adding dead code for Settings and State, which are being refactored anyways. This is just a stopgap for getting builds working again.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.75%. Comparing base (e2f918a) to head (d7c7464).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1738   +/-   ##
=======================================
  Coverage   16.75%   16.75%           
=======================================
  Files         213      213           
  Lines       20704    20704           
  Branches      871      871           
=======================================
  Hits         3468     3468           
  Misses      17236    17236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandonskiser brandonskiser marked this pull request as ready for review May 8, 2025 16:34
@brandonskiser brandonskiser requested a review from a team May 8, 2025 16:34
@brandonskiser brandonskiser enabled auto-merge (squash) May 8, 2025 17:37
auto-merge was automatically disabled May 8, 2025 19:52

Pull request was closed

@brandonskiser brandonskiser deleted the bskiser/fix-more-tests branch May 8, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants